Make SQLite a first-class tested backend#273
Open
AnnoyingTechnology wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
For the workload Davis serves, SQLite has concrete operational and technical advantages over a client/server DBMS:
The production examples and comparative measurements in SQLite does the job just fine illustrate these properties at substantially larger scales.
SQLite is already supported and documented by Davis, but it is not currently validated at the same level as MariaDB: the functional suite assumes a server database, SQLite receives migration coverage only, and the test bootstrap performs database provisioning that does not apply cleanly to SQLite.
This PR closes that gap and makes SQLite a first-class tested backend.
What changed
The PostgreSQL support level is unchanged. The sample driver name is corrected from postgresql to the Doctrine DBAL pgsql token.
Verification
This does not remove or downgrade support for MariaDB or PostgreSQL.