Fix precompilation: remove duplicate _foreach_typed_tolerant definition#40
Merged
Conversation
src/store.jl defined _foreach_typed_tolerant twice — an identical copy-paste
of the function and its doc comment. On Julia 1.12+ this fails module
precompilation ("Method overwriting is not permitted during Module
precompilation"), so a bare `using DatabentoAPI` errors. Pkg.test masks it by
falling back to no-precompile, which is why the test suite (and CI) stayed
green while the duplicate was present.
Removed the second copy; the package now precompiles cleanly. No behavior
change — the two definitions were byte-identical.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
src/store.jldefines the internal_foreach_typed_toleranthelper twice — an identical copy-paste of the function and its full doc comment (introduced alongside the tolerant-decode work in #30/#36). On Julia 1.12+ this fails module precompilation:So a bare
using DatabentoAPIerrors. The test suite (and CI) stayed green becausePkg.testfalls back to running without precompilation when precompile fails, masking the problem.Fix
Remove the second (duplicate) definition. The two were byte-identical, so there is no behavior change. The package now precompiles cleanly:
🤖 Generated with Claude Code