-
-
Notifications
You must be signed in to change notification settings - Fork 139
feat: add per-task types_of_exceptions #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
spikeninja
wants to merge
1
commit into
master
Choose a base branch
from
feat/add-per-task-retry-exceptions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| from typing import Any | ||
|
|
||
| from taskiq import InMemoryBroker | ||
| from taskiq.kicker import AsyncKicker | ||
|
|
||
|
|
||
| async def test_types_of_exceptions_not_serialized() -> None: | ||
| """`types_of_exceptions` label should never be sent over the wire.""" | ||
| broker = InMemoryBroker() | ||
|
|
||
| @broker.task(types_of_exceptions=(ValueError, TypeError)) | ||
| async def run_task() -> None: | ||
| pass | ||
|
|
||
| kicker = run_task.kicker() | ||
| message = kicker._prepare_message() | ||
|
|
||
| assert "types_of_exceptions" not in message.labels | ||
| assert "types_of_exceptions" not in (message.labels_types or {}) | ||
|
|
||
|
|
||
| async def test_types_of_exceptions_still_local_on_task() -> None: | ||
| """The registered task still keeps the real exception types locally.""" | ||
| broker = InMemoryBroker() | ||
|
|
||
| @broker.task(types_of_exceptions=(ValueError, TypeError)) | ||
| async def run_task() -> None: | ||
| pass | ||
|
|
||
| task = broker.find_task(run_task.task_name) | ||
| assert task is not None | ||
| assert task.labels["types_of_exceptions"] == (ValueError, TypeError) | ||
|
|
||
|
|
||
| async def test_other_labels_still_serialized() -> None: | ||
| """Unrelated labels are unaffected by the fix.""" | ||
| kicker: AsyncKicker[Any, Any] = AsyncKicker( | ||
| task_name="some_task", | ||
| broker=InMemoryBroker(), | ||
| labels={"retries": 3, "queue": "high_priority"}, | ||
| ) | ||
| message = kicker._prepare_message() | ||
|
|
||
| assert message.labels["retries"] == "3" | ||
| assert message.labels["queue"] == "high_priority" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.