fix: correctly normalize windows path in wasm#810
Open
Charlie-XIAO wants to merge 5 commits intotamasfe:masterfrom
Open
fix: correctly normalize windows path in wasm#810Charlie-XIAO wants to merge 5 commits intotamasfe:masterfrom
Charlie-XIAO wants to merge 5 commits intotamasfe:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #285.
#285 (comment) is right, currently the native version works for Windows, but if installed from npm, the wasm target is used which does not work for Windows.
This PR adds a method
to_unix_path_on_windowsthat converts windows-style path to unix-style path only if on windows platform. For browsers, this usesnavigator.userAgentthough I think these cases will not be hit. For CLI this usesprocess.platform. TheNormalize::normalizemethod now needs to take a reference toEnvironmentto be able to call this method.