PeerHelper: deduplicate self node in peer list to fix LazyColumn crash - #840
Open
D-Fed11 wants to merge 1 commit into
Open
PeerHelper: deduplicate self node in peer list to fix LazyColumn crash#840D-Fed11 wants to merge 1 commit into
D-Fed11 wants to merge 1 commit into
Conversation
With headscale servers, selfNode can already be present in netmap.Peers, causing it to appear twice in (peers + selfNode). Both entries share the same StableID, which triggers a KeyAlreadyUsed IllegalArgumentException in the MainView LazyColumn, crashing the app on launch. Fix by deduplicating on StableID before iterating. Verified working on Raspberry Pi 4 with headscale. Closes #20725 Ref tailscale#832
Member
|
But why is Headscale doing that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Android app crashes immediately on launch with headscale servers:
Root cause
PeerHelper.regenerateGroupedPeers()iterates over(peers + selfNode). With headscale,selfNodeis already present innetmap.Peers, so it gets added twice. Both entries share the sameStableID, which becomes a duplicate key inMainView'sLazyColumn.Fix
distinctBy { it.StableID }on the combined list before iterating.Testing
Verified working on Raspberry Pi 4 running LineageOS TV, authenticated against a headscale server. Before fix: crash on every launch. After fix: UI loads and functions correctly.
Refs