Skip to content

[codex] android: hide sharee peers from device list#771

Open
guanzi008 wants to merge 1 commit intotailscale:mainfrom
guanzi008:codex/hide-sharee-node-peers
Open

[codex] android: hide sharee peers from device list#771
guanzi008 wants to merge 1 commit intotailscale:mainfrom
guanzi008:codex/hide-sharee-node-peers

Conversation

@guanzi008
Copy link
Copy Markdown

What changed

This change hides ShareeNode peers from the normal Android device list.

Why

The control plane can include ShareeNode peers in the netmap for shared-device return-path coordination. These peers are transport-level/internal and are documented to be hidden by default in normal device listings.

The CLI already does this filtering, but the Android grouped peer list did not. As a result, users could see devices that were only present as hidden sharee peers.

Impact

  • Shared-device connectivity semantics stay intact.
  • Android users no longer see hidden sharee peers as ordinary devices in the peer list.
  • This aligns the Android UI with the existing CLI behavior and the ShareeNode contract.

Root cause

PeerHelper grouped every peer from the netmap into the visible device list without excluding Hostinfo.ShareeNode peers.

Validation

  • Pulled latest main before applying the change.
  • Reviewed parity with the CLI filtering behavior.
  • ./gradlew compileDebugKotlin could not be run in this environment because JAVA_HOME is not set and no java binary is available.

@guanzi008 guanzi008 marked this pull request as ready for review March 28, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant