[codex] android: hide sharee peers from device list#771
Open
guanzi008 wants to merge 1 commit intotailscale:mainfrom
Open
[codex] android: hide sharee peers from device list#771guanzi008 wants to merge 1 commit intotailscale:mainfrom
guanzi008 wants to merge 1 commit intotailscale:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This change hides
ShareeNodepeers from the normal Android device list.Why
The control plane can include
ShareeNodepeers in the netmap for shared-device return-path coordination. These peers are transport-level/internal and are documented to be hidden by default in normal device listings.The CLI already does this filtering, but the Android grouped peer list did not. As a result, users could see devices that were only present as hidden sharee peers.
Impact
ShareeNodecontract.Root cause
PeerHelpergrouped every peer from the netmap into the visible device list without excludingHostinfo.ShareeNodepeers.Validation
mainbefore applying the change../gradlew compileDebugKotlincould not be run in this environment becauseJAVA_HOMEis not set and nojavabinary is available.