Fix/restart vpn state bug

[SegiH]

Updates #17190

After enabling another VPN app in Android, you cannot enable the Tailscale radio toggle until you force stop it. The radio button will not enter the enabled state.

Steps to recreate this issue:

1. Enable Tailscale in Android app via radio toggle or Connect button.
2. Enable another VPN.
3. Return to Tailscale Android app and try to enable via radio toggle or Connect button. The radio toggle does not enter the enabled state. The Tailscale Quick Connect tile experiences this symptom as well.

When tracing this issue, I found that at step 3, a break point at this point shows that the value of currentState is Ipn.State.Stopping not Ipn.State.Stopped as you might expect. When you enable Tailscale initially in step 1, currentState is Ipn.State.Stopped.

Enabling/Disabling Tailscale is done in 2 places in the Android app and this PR is to fix this issue in 2 places:

1. After this line:

I check if the value of currentState is Ipn.State.Stopping and if it is, call stopVPN().

2. Tailscale can be enabled or disabled via the Tailscale tile. In QuickToggleService, the value of isRunning is set to true but is never set to false. As a result, before calling app.startVPN(), I added a call to app.stopVPN() to fix this issue since isRunning is not a reliable state to check the current status of Tailscale to determine if it is running.

I also added a note to the README that its required to run make libtailscale to make the Tailscale AAR necessary to build the Android Tailscale app.

[jaydenbarta]

Hey dude, nice fixes. I noticed the tileservice bug ages ago and I'm glad it's finally got a solution. Hope you can sign off on your commits so they can merge them asap and get this fixed!

[SegiH]

Thanks.

It's not up to me to sign off on my commits. I submitted a PR for the Tailscale devs.

They have to approve me PR and merge my change with master branch

[jaydenbarta]

I meant sign off with DCO as it's been auto declined due to that.

[SegiH]

oh yea thanks for pointing that out. I think its fixed now

[SegiH]

is there anything else that I need to do to push this along ?

[mio-19]

Github: This branch has conflicts that must be resolved

[SegiH]

@mio-19 I just resolved it

[MicroPanda123]

I don't know if it is related, but I have a similar issue where Tailscale sometimes randomly disconnects on network changes, and when this happens the toggle also breaks and I also have to force stop the app, so I really hope this gets merged and perhaps fixes my problem as well