Skip to content

fix: Windows MSI download on self-hosted runners #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doringeman wants to merge 1 commit into
base: main
Choose a base branch
from
+29 −14
Open

fix: Windows MSI download on self-hosted runners #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 29 additions & 14 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,23 +509,38 @@ async function installTailscaleWindows(

// Download MSI
const downloadUrl = `${baseUrl}/tailscale-setup-${config.resolvedVersion}-${config.arch}.msi`;
core.info(`Downloading ${downloadUrl}`);

const downloadedMsiPath = await tc.downloadTool(downloadUrl, msiPath);

// Verify checksum
const actualSha = await calculateFileSha256(downloadedMsiPath);
const expectedSha = config.sha256Sum.trim().toLowerCase();
core.info(`Expected sha256: ${expectedSha}`);
core.info(`Actual sha256: ${actualSha}`);
if (actualSha !== expectedSha) {
throw new Error("SHA256 checksum mismatch");

// Check if MSI already exists with correct checksum (for self-hosted runners)
let needsDownload = true;
if (fs.existsSync(msiPath)) {
const existingSha = await calculateFileSha256(msiPath);
if (existingSha === expectedSha) {
core.info(`Using existing MSI at ${msiPath} (checksum verified)`);
needsDownload = false;
} else {
core.info(`Existing MSI checksum mismatch, re-downloading`);
fs.unlinkSync(msiPath);
}
}

// Keep the MSI file in toolPath for caching (don't delete it)
// The downloadedMsiPath is in temp, but we want to keep it in toolPath
if (downloadedMsiPath !== msiPath) {
fs.copyFileSync(downloadedMsiPath, msiPath);
if (needsDownload) {
core.info(`Downloading ${downloadUrl}`);
const downloadedMsiPath = await tc.downloadTool(downloadUrl, msiPath);

// Verify checksum
const actualSha = await calculateFileSha256(downloadedMsiPath);
core.info(`Expected sha256: ${expectedSha}`);
core.info(`Actual sha256: ${actualSha}`);
if (actualSha !== expectedSha) {
throw new Error("SHA256 checksum mismatch");
}

// Keep the MSI file in toolPath for caching (don't delete it)
// The downloadedMsiPath is in temp, but we want to keep it in toolPath
if (downloadedMsiPath !== msiPath) {
fs.copyFileSync(downloadedMsiPath, msiPath);
}
}
}

Expand Down