Show a insufficient funds warning#3645
Closed
kkosiorowska wants to merge 1 commit intomainfrom
Closed
Conversation
Shadowfiend
reviewed
Oct 25, 2023
Comment on lines
+592
to
+598
| if ( | ||
| "annotation" in transactionRequest && | ||
| transactionRequest.annotation !== undefined | ||
| ) { | ||
| transactionRequest.annotation.warnings ??= [] | ||
| transactionRequest.annotation.warnings.push("insufficient-funds") | ||
| } |
Contributor
There was a problem hiding this comment.
We shouldn't be pushing annotations anywhere other than the enrichment service…
We also unfortunately have this estimation handling duplicated here and below in populatePartialEIP1559TransactionRequest.
Will think about the best way to tie these together.
Contributor
|
Closing as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing Env
Latest build: extension-builds-3645 (as of Fri, 20 Oct 2023 14:06:50 GMT).