Conversation
t2d
force-pushed
the
admin-delete-alias
branch
from
0b09a08 to
68a1088
Compare
t2d
requested review from
0x46616c6b,
doobry-systemli and
y3n4
as code owners
|
0x46616c6b
reviewed
Sep 6, 2025
t2d
force-pushed
the
admin-delete-alias
branch
from
68a1088 to
67bf3a6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
t2d
force-pushed
the
admin-delete-alias
branch
from
b9cea85 to
352a71c
Compare
|
0x46616c6b
approved these changes
Jan 30, 2026
Member
0x46616c6b
left a comment
0x46616c6b
left a comment
There was a problem hiding this comment.
Only open question (but not related to this change): When you delete a shared alias, will only the reference to the current user be deleted or the whole alias?
Contributor
Author
|
The database doesn't know shared aliases. These are simply multiple aliases with the same source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Admin:
User:
