Skip to content

kbled: Use defines for PWM DCRs to use #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crawfxrd wants to merge 1 commit into
base: master
Choose a base branch
from
Open

kbled: Use defines for PWM DCRs to use #567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 13 additions & 20 deletions src/app/main/kbled/rgb_pwm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
#include <board/gpio.h>
#include <ec/pwm.h>

#define KBLED_BRI DCR0
#define KBLED_RED DCR5
#define KBLED_GREEN DCR6
#define KBLED_BLUE DCR7

void kbled_init(void) {
if (!gpio_get(&RGBKB_DET_N)) {
kbled_kind = KBLED_RGB;
Expand All @@ -22,31 +27,24 @@ void kbled_reset(void) {
}

uint8_t kbled_get(void) {
// Get PWM for power
return DCR0;
return KBLED_BRI;
}

uint8_t kbled_max(void) {
return 255;
}

void kbled_set(uint8_t level) {
// Set PWM for power
DCR0 = level;
KBLED_BRI = level;
}

uint32_t kbled_get_color(void) {
if (kbled_kind == KBLED_WHITE)
return 0xFFFFFF;

// Get PWM of blue component
uint32_t color = (uint32_t)DCR7;

// Get PWM of green component
color |= ((uint32_t)DCR6) << 8;

// Get PWM of red component
color |= ((uint32_t)DCR5) << 16;
uint32_t color = (uint32_t)KBLED_BLUE;
color |= ((uint32_t)KBLED_GREEN) << 8;
color |= ((uint32_t)KBLED_RED) << 16;

return color;
}
Expand All @@ -55,12 +53,7 @@ void kbled_set_color(uint32_t color) {
if (kbled_kind == KBLED_WHITE)
color = 0xFFFFFF;

// Set PWM for blue component
DCR7 = (uint8_t)(color);

// Set PWM for green component
DCR6 = (uint8_t)(color >> 8);

// Set PWM for red component
DCR5 = (uint8_t)(color >> 16);
KBLED_BLUE = (uint8_t)(color);
KBLED_GREEN = (uint8_t)(color >> 8);
KBLED_RED = (uint8_t)(color >> 16);
}