mb/system76/mtl: Fix TCP2 DDI mapping#278
Open
crawfxrd wants to merge 1 commit into
Open
Conversation
Change-Id: I047f2684827acc1f05d7b8ed1d5e64483e17b08d Signed-off-by: Tim Crawford <tcrawford@system76.com>
leviport
approved these changes
Jun 5, 2026
leviport
left a comment
leviport
left a comment
Member
There was a problem hiding this comment.
Tested on lemp13-b. Hotplugging HDMI worked before this change, but it also still works after the change.
jackpot51
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upstream: https://review.coreboot.org/c/coreboot/+/93284
HDMI_HPDis connected toDDSP_HPD2. Since MTL, DDSP is also 0-indexed, but port mappings remain 1-indexed.Does HDMI HPD work on MTL boards?
Do TBT/USB-C need to be added to
ddi_ports_configas well?Intel also just pushed this for Google Atria (NVL)
TCP[0-2] are used, but not declared in the FSP config. Only eDP on DDI-A and HDMI on "DDI-4", which I can only assume is TCP3.