fix: default listening host to all interfaces for container compatibility#69
Merged
tembleking merged 3 commits intomainfrom Mar 3, 2026
Merged
fix: default listening host to all interfaces for container compatibility#69tembleking merged 3 commits intomainfrom
tembleking merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the server’s default network bind address to improve out-of-the-box connectivity in containerized deployments, alongside a patch release bump and dependency/Nix lock refresh.
Changes:
- Default
SYSDIG_MCP_LISTENING_HOSTfromlocalhostto0.0.0.0(and update config tests/docs accordingly). - Bump package version to
1.0.3and refresh Nix vendoring hash/flake lock. - Upgrade several Go dependencies and update
go.sum.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
internal/config/config.go |
Changes default listening host to 0.0.0.0. |
internal/config/config_test.go |
Updates expectations for the new default listening host. |
README.md |
Updates documented defaults/examples and removes now-redundant K8s env var. |
go.mod |
Bumps dependency versions. |
go.sum |
Updates dependency checksums/pseudo-versions. |
package.nix |
Bumps package version and vendor hash. |
flake.lock |
Updates pinned nixpkgs revision/hash. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…lity When running inside a container, binding to localhost only accepts connections from within the container itself. Traffic from port forwarding arrives via the bridge network interface, not loopback, causing connection resets. Defaulting to all interfaces ensures the server is reachable without requiring an explicit override.
tembleking
force-pushed
the
fix/default-listening-host
branch
from
19630ab to
19a9c3f
Compare
tembleking
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running inside a container, binding to
localhostonly accepts connections from within the container itself. Traffic from port forwarding arrives via the bridge network interface, not loopback, causing connection resets.Changing the default to bind on all interfaces (
:port) ensures the server is reachable out of the box in containerized deployments, with dual-stack IPv4/IPv6 support. Users can setSYSDIG_MCP_LISTENING_HOST=127.0.0.1for local-only access.Also bumps the patch version to
1.0.3and updates dependencies.