Optional config to require a login to access the terminal.#9
Open
oskar-kupski-elpassion wants to merge 2 commits intosyntaxseed:masterfrom
Open
Optional config to require a login to access the terminal.#9oskar-kupski-elpassion wants to merge 2 commits intosyntaxseed:masterfrom
oskar-kupski-elpassion wants to merge 2 commits intosyntaxseed:masterfrom
Conversation
Owner
|
Is this still a work in progress?
Looks great though. I will try it out soon. |
Author
|
My bad, it's not configurable yet. I will add it today tough
…On Wed, Oct 2, 2019 at 5:04 PM SyntaxSeed ***@***.***> wrote:
Is this still a work in progress?
- The username and password should be configurable and password should
be hashed.
Looks great though. I will try it out soon.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9?email_source=notifications&email_token=ANLOPPNRFK4DCT3ZAEJROJ3QMS2A5A5CNFSM4I4V4OWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAFCQXQ#issuecomment-537536606>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ANLOPPPQ4RMSU53DDKRVY53QMS2A5ANCNFSM4I4V4OWA>
.
|
Author
|
Hi, I moved, the configuration of username and password to index.html file. If they are not defined and login is required an error is thrown. Please let me know if it meets your expectations now :) |
Owner
|
Note that PR #13 will be merged before the others once it is fully reviewed. This one may need a rebase at that time. Thanks! |
Owner
|
Please rebase & test now that a major refactor has been merged. Thanks! |
syntaxseed
added
the
needs rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4