Merged
Conversation
spawn_background_processor_task is reserved for the single LDK background processor. The external scores sync was incorrectly using it, which caused a debug_assert panic when Node::start() later tried to spawn the actual background processor. Switch to spawn_cancellable_background_task which matches the pattern used by other periodic background tasks (RGS sync, peer reconnection, broadcast queue).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawn_background_processor_taskmisuse inscoring.rs— switch tospawn_cancellable_background_taskProblem
spawn_background_processor_taskis reserved for the single LDK background processor (process_events_async). The external pathfinding scores sync was incorrectly using it, which setbackground_processor_tasktoSome(...)beforeNode::start()reached line 617 where the actual background processor is spawned.This caused a
debug_assert!panic in debug builds:In release builds, the
debug_assertis a no-op, so the background processor task handle was silently overwritten — meaning the actual LDK event processor would never be properly awaited during shutdown.Fix
Switch to
spawn_cancellable_background_task, matching the pattern used by other periodic background tasks (RGS sync, peer reconnection, broadcast queue).Test plan
runtime.rs:93)