fix: bump feerate and tx broadcast timeouts to 15s#64
Merged
Conversation
The 5-second node-level timeout fires before Electrum can complete a single request (10s timeout), causing FeerateEstimationUpdateTimeout on node start. Bump both FEE_RATE_CACHE_UPDATE_TIMEOUT_SECS and TX_BROADCAST_TIMEOUT_SECS from 5s to 15s. Upstream fixed this in lightningdevkit/ldk-node@40c4b09 (bumped to 10s). We use 15s for extra margin with slow Electrum servers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FEE_RATE_CACHE_UPDATE_TIMEOUT_SECSfrom 5s to 15sTX_BROADCAST_TIMEOUT_SECSfrom 5s to 15sProblem
The 5-second node-level timeout fires before Electrum can complete a single request (10s timeout), causing
FeerateEstimationUpdateTimeoutonnode.start(). This breaks integration tests and any Electrum-backed setup.Upstream fixed this in lightningdevkit/ldk-node@40c4b09 (bumped to 10s). We use 15s for extra margin with slow Electrum servers.
Test plan
FeerateEstimationUpdateTimeout)