feat: redesign price widget to Figma v61#542
Open
jvsena42 wants to merge 23 commits intofeat/os-widgetsfrom
Open
feat: redesign price widget to Figma v61#542jvsena42 wants to merge 23 commits intofeat/os-widgetsfrom
jvsena42 wants to merge 23 commits intofeat/os-widgetsfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4dfd9a80d0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
8 tasks
…-widget-v61 # Conflicts: # BitkitWidget/PriceHomeScreenWidget.swift
…ios into feat/price-widget-v61
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR redesigns the Bitcoin Price widget to match Figma v61.
The home-screen widget now picks between two layouts based on its rendered family: a Wide layout (medium) with a 34pt headline price and a thin chart, and a Compact layout (small) with a stacked title, change %, and a taller chart. The Large family is removed. The chart drops its previous gradient fill in favor of a line-only stroke, and the period overlay is removed since the timeframe label now lives in the header.
Currency selection moves from a multi-toggle list to single-select.
PriceWidgetOptions.selectedPairs: [String]becomesselectedPair: String("BTC/USD" by default), with a custom Codable shim that decodes legacy v60 storage by reading the first element of the old array — so existing users upgrade without losing their pair.The edit screen is restructured into two single-select sections — Currency and Timeframe — with the active row in white text and a brand-orange checkmark. Timeframes display as full words ("Day", "Week", "Month", "Year") on the edit screen but as their abbreviations ("1D", "1W", "1M", "1Y") inside the widget itself. The
showSourcetoggle is gone.The preview screen replaces the headline + icon header with a centered "Bitcoin Price" top bar, description block, "Widget Settings" cell, and a horizontal carousel that swipes between the small and wide widget previews with a size label and dot indicator below. The Save button reads "Save Widget", and the navigation drawer/menu is hidden on both Preview and Edit screens.
While in there: fixed an ordering bug in
BitkitWidget/PriceWidgetService.fetchFreshPricesflagged on #538 —withTaskGroupresults are now paired with their input index and sorted before returning so the headline pair stays stable across cache↔fresh refreshes.Mirrors the v61 redesign shipped on Android in bitkit-android#914.
Linked Issues/Tasks
N/A
Screenshot / Video
os-widget.mp4
in-app-widget.mp4
migration.mp4
QA Notes
1. Home-screen widget
BTC/USD 1Dcaption, 34pt price, change % on the right, line-only chart).BTC/USDleft /1Dright, 22pt price, change % below, taller line chart).2. In-app price widget
3. Preview screen
4. Edit screen
5. Upgrade safety
selectedPairs: ["BTC/USD", "BTC/EUR"]andshowSource: truestored on disk) launch without crashes; the first pair is picked up as the newselectedPairandshowSourceis silently ignored.