Skip to content

[codex] fix public payments polish#933

Open
ben-kaufman wants to merge 1 commit intomasterfrom
codex/fix-public-payments-polish
Open

[codex] fix public payments polish#933
ben-kaufman wants to merge 1 commit intomasterfrom
codex/fix-public-payments-polish

Conversation

@ben-kaufman
Copy link
Copy Markdown
Contributor

Fixes #931

Description

Polishes the public contact payment flows from PR #924:

  • Routes Pubky keys entered manually through the same contact/profile resolution used by paste and scan.
  • Pops the Add Contact screen before opening the payment flow, avoiding the background Add Contact screen glitch.
  • Preserves contact metadata on RBF replacement transactions and filters replaced sent transactions from contact activity.
  • Shares the replaced-sent-transaction predicate through the existing activity extension layer.

Preview

N/A

QA Notes

Validated with:

  • ./gradlew testDevDebugUnitTest --tests "to.bitkit.repositories.ActivityRepoTest" --tests "to.bitkit.viewmodels.AppViewModelSendFlowTest"
  • ./gradlew compileDevDebugKotlin
  • ./gradlew testDevDebugUnitTest
  • ./gradlew detekt

Suggested manual checks:

  • Send -> Enter manually with a Pubky key routes to the expected contact/profile flow.
  • Paying a contact from Add Contact opens the send flow without leaving Add Contact visible behind it.
  • RBF a sent contact transaction and confirm contact activity shows the replacement transaction rather than the removed mempool transaction.

@ben-kaufman ben-kaufman marked this pull request as ready for review May 6, 2026 01:53
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 6, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@piotr-iohk
Copy link
Copy Markdown
Collaborator

Tested. Seeing two out of three original issues:

  • Send -> Enter manually with a Pubky key routes to the expected contact/profile flow. ❌
  • Paying a contact from Add Contact opens the send flow without leaving Add Contact visible behind it. ❌
Screen.Recording.2026-05-06.at.09.04.59.mov

  • RBF a sent contact transaction and confirm contact activity shows the replacement transaction rather than the removed mempool transaction. ✅
Screenshot 2026-05-06 at 09 06 32

Copy link
Copy Markdown
Collaborator

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing two issues.

Base automatically changed from codex-public-payments-contacts to master May 6, 2026 08:30
@ovitrif ovitrif added this to the 2.3.0 milestone May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Public payments polish

3 participants