chore: improve GenAI tests in PR descriptions#928
Conversation
7322d27 to
788add8
Compare
This comment has been minimized.
This comment has been minimized.
| #### Automated Checks | ||
| - [x] ./gradlew compileDevDebugKotlin | ||
| - [x] ./gradlew testDevDebugUnitTest | ||
| - [x] ./gradlew detekt |
There was a problem hiding this comment.
nit: could also list what coverage/modified/removed etc. was added, e.g.
- unit tests covering X added - link to file(s)
- unit tests covering Y modified - like to file(s)
- unit tests covering Z removed - state why
There was a problem hiding this comment.
Good point 🙌, iterating on this
There was a problem hiding this comment.
Addressed in 0ac9ad4.
Updated #### Automated Checks to prioritize coverage added, modified, or removed with file paths and short explanations, including a reason when automated coverage is removed.
|
@piotr-iohk & @jvsena42 this is ready for another pass, added new commit to keep automated checks grouped under their own heading. Once approved, I will port it to iOS. |
| - [x] ./gradlew compileDevDebugKotlin | ||
| - [x] ./gradlew testDevDebugUnitTest | ||
| - [x] ./gradlew detekt |
There was a problem hiding this comment.
These commands are always done by the CI or PR bot, IDK how useful it is place them in the description
- ./gradlew compileDevDebugKotlin
- ./gradlew testDevDebugUnitTest
- ./gradlew detekt
There was a problem hiding this comment.
Addressed in 0ac9ad4.
Updated the guidance to avoid listing standard CI or PR bot commands as checkbox items by default. Standard CI is now summarized in one sentence when useful, and raw commands are reserved for local, non-standard, special-flag, workflow, or gap-explaining checks.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This PR improves the shared
/prinstructions so AI-generated PR descriptions split QA notes into focused manual validation and visible automated check coverage.Description
This PR:
### QA Noteswith#### Manual Testsand#### Automated Checks.(after merge)caveat./prand/releasecommand specs into.agents/commandswhile keeping.claude/commandsas a compatibility symlink.Preview
N/A
QA Notes
Manual Tests
.claude/commands:pr.mdandrelease.mdresolve through the symlink.AGENTS.md: durable PR command behavior points to.agents/commands/pr.md./pr --dryin Claude Code → generate a PR body:QA Notescontains separateManual TestsandAutomated Checkssections.Automated Checks