Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
app/src/main/java/to/bitkit/ui/screens/transfer/external/ExternalNodeViewModel.kt
Outdated
Show resolved
Hide resolved
Contributor
Screen.Recording.2026-03-06.at.15.37.58.mov |
Collaborator
|
Note / observation. There is a little discrepancy in behavior between Android and iOS: In those cases iOS shows both toast and success / error screen:
This edge case is not handled in iOS
Probably should be reported in iOS. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
@pwltr fixes:
🆕 Dev testsNew dev tests, also added to PR description.
|
Collaborator
Author
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






This PR adds a pending payment UI for Lightning sends that take longer than expected (e.g. hold invoices).
Description
SendPendingScreenwith an hourglass animation, shown when a Lightning payment exceeds the 10-second timeout without resolvingPendingPaymentResolutiontracking inLightningReposo payment success/failure events are routed back to the pending screenPreview
Recording
tests_1.75x.mp4
edges_1.75x.mp4
QA Notes
Setup
bitkit-docker:docker compose up -dcurl -sL https://gist.githubusercontent.com/ovitrif/ac13a7ba09efd4c12bee0a1b4cc27f4a/raw/local-electrum.patch | git applyUse
./bitcoin-cliinbitkit-dockerfor hold invoices ops:Tests
Edge Cases
No need for reviewer(s) to test edge cases, they're listed here for transparency into what was dev-tested.
🤖 Generated with Claude Code