Open
Conversation
Contributor
|
Thanks for the contribution! |
ddwightx
reviewed
Sep 30, 2025
| } | ||
|
|
||
| public static ContentType get(burp.api.montoya.http.message.ContentType contentType) { | ||
| if (contentType == null) { |
| if (!encoder.isUseDefault() && encoder.isAutoSet() && !getContentType().isTextBased()) { | ||
| encoder.setEncoding("default", true); | ||
| } | ||
| initialized = true; |
Contributor
There was a problem hiding this comment.
Can you give your thought process on this move?
Author
There was a problem hiding this comment.
Hi, A recursive loop materializes when the initialize() method invokes getContentType(), which in turn calls back to initialize(). To resolve this circular dependency, the initialized = true; statement should be relocated to the very top of the if (!initialized) block within the initialize() method. This strategic placement dismantles the recursive cycle; upon its subsequent invocation by getContentType(), the initialize() method will encounter the pre-set flag and return immediately, thereby preempting the redundant execution of the initialization logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rectifying the NullPointerException error encountered within the latest version of Burp.