Skip to content

Commit ec5102f

Browse files
committed
Warnings are errors for everything
Missed a couple things last time. Ideally we'd have a better way to make sure we have this everywhere Topic: sym-werror-everywhere
1 parent 443997a commit ec5102f

3 files changed

Lines changed: 11 additions & 0 deletions

File tree

symforce/benchmarks/CMakeLists.txt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,10 @@ function(add_matrix_multiplication_benchmark matrix_name)
112112
matrix_multiplication/gen/matrix_multiplication_benchmark_${matrix_name}.cc
113113
)
114114

115+
target_compile_options(matrix_multiplication_benchmark_${matrix_name}
116+
PRIVATE ${SYMFORCE_COMPILE_OPTIONS}
117+
)
118+
115119
target_link_libraries(
116120
matrix_multiplication_benchmark_${matrix_name}
117121
Catch2::Catch2WithMain
@@ -138,6 +142,8 @@ add_executable(
138142
inverse_compose_jacobian/inverse_compose_jacobian_benchmark.cc
139143
)
140144

145+
target_compile_options(inverse_compose_jacobian_benchmark PRIVATE ${SYMFORCE_COMPILE_OPTIONS})
146+
141147
find_package(Sophus REQUIRED)
142148
target_link_libraries(
143149
inverse_compose_jacobian_benchmark
@@ -159,6 +165,8 @@ add_executable(
159165
robot_3d_localization/robot_3d_localization_benchmark.cc
160166
)
161167

168+
target_compile_options(robot_3d_localization_benchmark PRIVATE ${SYMFORCE_COMPILE_OPTIONS})
169+
162170
target_link_libraries(
163171
robot_3d_localization_benchmark
164172
gtsam

symforce/examples/bundle_adjustment_in_the_large/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ add_executable(
88
bundle_adjustment_in_the_large.cc
99
)
1010

11+
target_compile_options(bundle_adjustment_in_the_large_example PRIVATE ${SYMFORCE_COMPILE_OPTIONS})
12+
1113
target_link_libraries(
1214
bundle_adjustment_in_the_large_example
1315
symforce_gen

test/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ foreach(SOURCE_FILE ${SYMFORCE_TEST_CC_SOURCES})
5252
set_target_properties(${TARGET_NAME} PROPERTIES OUTPUT_NAME ${BINARY_NAME})
5353
set_target_properties(${TARGET_NAME} PROPERTIES TEST_NAME ${TEST_NAME})
5454
set_target_properties(${TARGET_NAME} PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)
55+
target_compile_options(${TARGET_NAME} PRIVATE ${SYMFORCE_COMPILE_OPTIONS})
5556
target_link_libraries(
5657
${TARGET_NAME}
5758
symforce_gen

0 commit comments

Comments
 (0)