Skip to content

Add support for php.new (herd-lite)#26

Merged
fabpot merged 2 commits into
symfony-cli:mainfrom
Kocal:windows-herd-lite
Sep 19, 2025
Merged

Add support for php.new (herd-lite)#26
fabpot merged 2 commits into
symfony-cli:mainfrom
Kocal:windows-herd-lite

Conversation

@Kocal

@Kocal Kocal commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

I suppose it works, but I haven't been able to test it.

With Go, how can I use my PR with the Symfony CLI, so I can try to see if local:php:list gives me PHP from herd-lite directory?

Close #25

@tucksaun

tucksaun commented Jul 2, 2025

Copy link
Copy Markdown
Member

With Go, how can I use my PR with the Symfony CLI, so I can try to see if local:php:list gives me PHP from herd-lite directory?

I wrote some directions in the main repo to do so: https://github.com/symfony-cli/symfony-cli/blob/main/CONTRIBUTING.md#additional-repositories

@tucksaun tucksaun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we add support for php.new on Linux and macOS as well?

Comment thread discovery_windows.go Outdated
Comment thread discovery_windows.go Outdated
@Kocal

Kocal commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

shouldn't we add support for php.new on Linux and macOS as well?

Totally, given the installation files, PHP should be available at $HOME/.config/herd-lite/bin/php on Linux and Mac.

@tucksaun

tucksaun commented Jul 3, 2025

Copy link
Copy Markdown
Member

shouldn't we add support for php.new on Linux and macOS as well?

Totally, given the installation files, PHP should be available at $HOME/.config/herd-lite/bin/php on Linux and Mac.

Great 👍
This means we could move the logic to discovery.go and benefit from it on every system.

@Kocal Kocal force-pushed the windows-herd-lite branch from 6f0f7f2 to aa1f7ac Compare July 9, 2025 18:03
@Kocal Kocal changed the title [Windows] Add support for php.new (herd-lite) Add support for php.new (herd-lite) Jul 9, 2025
@Kocal

Kocal commented Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

PR updated, I still didn't try it locally tho

@tucksaun tucksaun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small cosmetic suggestion, but LGTM overall

Comment thread discovery.go Outdated
Co-authored-by: Tugdual Saunier <tucksaun@users.noreply.github.com>
@fabpot fabpot merged commit ed9e0a2 into symfony-cli:main Sep 19, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[Windows] Add support for php.new and scoop

3 participants