makefile: don't do a go clean -cache when building the starter (release-4.4)#4065
Merged
dtrudg merged 2 commits intosylabs:release-4.4from Apr 1, 2026
Merged
makefile: don't do a go clean -cache when building the starter (release-4.4)#4065dtrudg merged 2 commits intosylabs:release-4.4from
dtrudg merged 2 commits intosylabs:release-4.4from
Conversation
Clobbering the Go cache is quite nasty in local builds, and painful in CI. The starter C code is changed little enough that requiring a manual `go clean -cache` to pick up changes is reasonable. This PR undoes the changes from: apptainer/singularity#2288 It adds a note to CONTRIBUTING.md and the C source/header files r.e. cleaning the cache to pick up modifications to the C code. See also https://pkg.go.dev/cmd/go#hdr-Build_and_test_caching See also apptainer/apptainer#3388
Cache checksum now covers starter C code modification times, as well as go.sum, so the build cache is not used if the starter C code has changed. Avoids the issue documented in: https://pkg.go.dev/cmd/go#hdr-Build_and_test_caching
wobito
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pick #4060 onto the release-4.4 branch