jextract/jni: Handle unexpected types gracefully in Map#732
Open
sidepelican wants to merge 1 commit intoswiftlang:mainfrom
Open
jextract/jni: Handle unexpected types gracefully in Map#732sidepelican wants to merge 1 commit intoswiftlang:mainfrom
sidepelican wants to merge 1 commit intoswiftlang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Java, methods such as
Map.get(Object key)orMap.containsKey(Object key)are designed to accept any Object.However, the current Swift implementation assumes a specific type will be passed.
If a value of an unexpected type is encountered, it leads to a runtime crash.
I have updated the implementation to handle type mismatches.
Instead of crashing, the code now aligns with standard Java semantics by returning
nullorfalse.