wrap-java: Avoid generic parameter shadowing#630
Merged
ktoso merged 7 commits intoswiftlang:mainfrom Mar 19, 2026
Merged
Conversation
ktoso
approved these changes
Mar 19, 2026
Collaborator
ktoso
left a comment
There was a problem hiding this comment.
I like this, agreed that a bit "hacky" but overall pretty good idea. Doing numbering like T1 etc would be a pain to maintain and why I've not gotten to this still... this is way easier to maintain and we do the type alias even as well... Sounds good to me!
This made it just in time for the 0.1.0 tag which I'll do today! 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #169.
Problem
It is difficult to find guaranteed unique names for generic parameters across inheritance hierarchies and enclosing classes.
This is because subclasses or nested types may remap their own generic parameters recursively.
Approach
This PR implements a simple but effective workaround for #169 using the following hack.
I prefix generic parameter names with their class name. This ensures uniqueness in most cases without requiring complex tree traversal.
I also use a
typealiasto avoid shadowing warnings. It is somewhat hacky, but effective.