jextract: Implement Java-side integer overflow checks for FFM mode (#517) #546
+554
−309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
reviewed
Jan 31, 2026
DPrakashhh
force-pushed
the
feature/jextract-overflow-check-517
branch
2 times, most recently
from
9065f02 to
e85d9fb
Compare
DPrakashhh
force-pushed
the
feature/jextract-overflow-check-517
branch
from
e85d9fb to
c586ffc
Compare
…has32bitSwiftInt helper
Author
|
I’ve updated the logic to use the new Please let me know if you’d prefer the formatting changes removed; otherwise, the logic is ready for another look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary: This PR aligns FFM mode with JNI by moving integer validation to the Java side. This prevents native crashes by catching out-of-range values before they reach Swift.
Key Changes
1-Java-Side Validation: Moved range checks from native thunks to Java wrappers using a shared
ArithmeticExceptionhelper.2-Type Widening: Parameters (e.g.,
Int8/16/32) are now widened in Java to allow safe bounds checking against Swift's target limits.3-Unsigned Handling: Added specific checks to bridge the gap between Java's signed types and Swift's
UInttypes.4-Updated Tests: Adjusted "golden" expectations for
UnsignedNumberTests,MethodImportTests, and others to reflect new safety logic.Verification
1-Full Suite: All 201 tests passed across 41 suites.
2-Toolchain: Verified on JDK 25 and Swift 6.2.1.