Conversation
| type: string | ||
| description: "Android Swift SDK version list (JSON)" | ||
| default: "[\"nightly-main\", \"nightly-6.3\"]" | ||
| default: "[\"nightly-main\", \"nightly-6.3\", \"6.3\"]" |
There was a problem hiding this comment.
Should we remove nightly-6.3 by default? I don't see it adding value for most devs.
There was a problem hiding this comment.
I was following Static Linux precedent:
github-workflows/.github/workflows/swift_package_test.yml
Lines 57 to 60 in 61db691
I don't know if it adds value for devs, but it might add value for us so we can more quickly identify any regressions that may come with the 6.3 nightlies.
I can go either way with it. WDYT, @shahmishal?
There was a problem hiding this comment.
That's even worse: no way static linux SDK users still want the old last 6.2 nightly snapshot built against, a complete waste.
We really need to prune that default version list for all platforms, starting with nightly-6.3 for Android in this pull. The others we can do in another pull, once the reviewers chime in on what they want.
There was a problem hiding this comment.
That's even worse: no way static linux SDK users still want the old last 6.2 nightly snapshot built against, a complete waste.
Well, I'm guessing that they just haven't updated it for 6.3 yet.
There was a problem hiding this comment.
Those 6.2 nightlies should have been dropped once 6.2 was tagged or soon after.
3 participants
This PR adds 6.3 to the default
android_sdk_versionsfor CI, and also fixes an error with getting the checksum for the final release of the Android SDK in 6.3. This wasn't affecting the earlier nightly-6.3 or nightly-main because their checksum fetching is done in a different place.