Skip to content

When splitting lines for the cross-PR checkout also split on \r\n #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahoppen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

When splitting lines for the cross-PR checkout also split on \r\n #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/scripts/cross-pr-checkout.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ struct CrossRepoPR {
func getCrossRepoPrs(repository: String, prNumber: String) async throws -> [CrossRepoPR] {
var result: [CrossRepoPR] = []
let prInfo = try await getPRInfo(repository: repository, prNumber: prNumber)
for line in prInfo.body?.split(separator: "\n") ?? [] {
for line in prInfo.body?.split(whereSeparator: \.isNewline) ?? [] {
guard line.lowercased().starts(with: "linked pr:") else {
continue
}
Expand Down
Loading