Added section to emphasize difference between exceptions and assertions#1
Open
aabiddanda wants to merge 3 commits intoswcarpentry:gh-pagesfrom
aabiddanda:gh-pages
Open
Added section to emphasize difference between exceptions and assertions#1aabiddanda wants to merge 3 commits intoswcarpentry:gh-pagesfrom aabiddanda:gh-pages
aabiddanda wants to merge 3 commits intoswcarpentry:gh-pagesfrom
aabiddanda:gh-pages
Conversation
added 3 commits
November 8, 2016 11:28
… to use exceptions rather than assertion
Author
|
Would love to hear other opinions on what best practices are for using assertions vs. exceptions! I just thought that it would be helpful to make this distinction early on in the lesson to avoid confusion later on |
|
Hi @aabiddanda -- I'm sorry for the delay in looking at this. Unfortunately, the reason is that this is not the main fork of this repository. I'm happy to merge new changes in this fork to the actual main fork (katyhuff/python-testing), but it would be much simpler if you re-issue this PR to the main fork (https://github.com/katyhuff/python-testing). Would you mind if we close this PR and conduct the review over in the main one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also fixed a couple of typos as well as updated the learning objectives to be framed more from the learners perspective