fix: add nba.com Referer header to live endpoint requests#671
Open
OnerInce wants to merge 1 commit into
Open
Conversation
cdn.nba.com now returns 403 for liveData requests without an nba.com Referer (ScoreBoard, PlayByPlay, BoxScore, Odds). Add it to the live HTTP default headers, matching the stats client. Fixes swar#670
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cdn.nba.comstarted returning403forliveDatarequests that don't carry annba.comRefererheader, which breaks theliveendpoints (ScoreBoard,PlayByPlay,BoxScore,Odds). ThestatsHTTP client already sendsReferer: https://www.nba.com/; this adds the same header to theliveclient's default headers.Fixes #670
Change
src/nba_api/live/nba/library/http.py: add"Referer": "https://www.nba.com/"to theSTATS_HEADERSfallback dict.Verification
pytest tests/unit/live tests/unit/httppasses (the 2test_get_request_urlfailures are pre-existing onmaster— they hit the live CDN with a stale 2021 game id, unrelated to this change).