Use correct method to read contents of a java.nio.file.Path - #1937
Closed
makkarpov wants to merge 1 commit into
Closed
Use correct method to read contents of a java.nio.file.Path#1937makkarpov wants to merge 1 commit into
makkarpov wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the PR! The diagnosis here was correct. However, this issue has since been addressed by #2320, which implements the same provider neutral Path handling and includes regression coverage for non-default file systems. Since that fix is now merged into master I am closing it as superseded by #2320. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toFile()fails when underlying path denotes virtual files (i.e. inside JARs on classpath).readAllBytesworks with all filesystems transparently.