Make sure to display the error message on overlay#67
Closed
maxlath wants to merge 1 commit intosveltejs:masterfrom
Closed
Make sure to display the error message on overlay#67maxlath wants to merge 1 commit intosveltejs:masterfrom
maxlath wants to merge 1 commit intosveltejs:masterfrom
Conversation
as some errors might be passed to addError with a stack attributes not including the error message
Collaborator
|
Hi! Thanks for your interest in making svelte-hmr better, but to be honest this overlay is kind of headed toward the exit door. It surely won't make it to the next major version of svelte-hmr. I am curious about your use case, though. The overlay is disabled with Vite, so are you using Webpack? Rollup? And how is this specific overlay useful to you? (Or annoying, since apparently it eats your error message? 😅 ) |
Author
|
I work on a project where we are sticking with webpack, as we are still phasing out our Backbone+Handlebars legacy code in favor of Svelte, and thus still use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as some errors might be passed to
addErrorwith astackattribute not including the errormessage