Skip to content

Make sure to display the error message on overlay#67

Closed
maxlath wants to merge 1 commit intosveltejs:masterfrom
maxlath:recover-error-message
Closed

Make sure to display the error message on overlay#67
maxlath wants to merge 1 commit intosveltejs:masterfrom
maxlath:recover-error-message

Conversation

@maxlath
Copy link
Copy Markdown

@maxlath maxlath commented Mar 16, 2023

as some errors might be passed to addError with a stack attribute not including the error message

as some errors might be passed to addError with a stack attributes not including the error message
@rixo
Copy link
Copy Markdown
Collaborator

rixo commented Mar 17, 2023

Hi! Thanks for your interest in making svelte-hmr better, but to be honest this overlay is kind of headed toward the exit door. It surely won't make it to the next major version of svelte-hmr.

I am curious about your use case, though. The overlay is disabled with Vite, so are you using Webpack? Rollup? And how is this specific overlay useful to you? (Or annoying, since apparently it eats your error message? 😅 )

@maxlath
Copy link
Copy Markdown
Author

maxlath commented Mar 18, 2023

I work on a project where we are sticking with webpack, as we are still phasing out our Backbone+Handlebars legacy code in favor of Svelte, and thus still use svelte-loader during the transition. The overlay is then quite useful to get a quick feedback on failing code; that is, unless it eats error messages indeed ^^

@maxlath maxlath closed this by deleting the head repository Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants