Skip to content

fix: rewrite TypeScript glob extensions (svelte-package) - #16776

Merged
Rich-Harris merged 1 commit into
sveltejs:version-3from
Boulea7:fix/package-glob-extensions
Aug 13, 2026
Merged

fix: rewrite TypeScript glob extensions (svelte-package)#16776
Rich-Harris merged 1 commit into
sveltejs:version-3from
Boulea7:fix/package-glob-extensions

Conversation

@Boulea7

@Boulea7 Boulea7 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

closes #9423

With rewriteRelativeImportExtensions enabled, svelte-package already emits .ts modules as .js and rewrites explicit imports. Static import.meta.glob patterns were left pointing at the source extension, so they no longer matched the packaged files.

This applies the same rewrite to relative static glob patterns, including arrays, negated patterns, and no-substitution template literals. Dynamic patterns and calls that are not Vite's exact import.meta.glob form remain unchanged.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Validated with:

  • pnpm run format
  • pnpm run lint
  • pnpm run check
  • pnpm -F @sveltejs/package test
  • pnpm -F @sveltejs/kit test:unit

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from d849917:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/d84991704e34e14128c56a0f94dfd71f03c27f87

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16776

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d849917

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/package Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@teemingc teemingc added the pkg:svelte-package Issues related to svelte-package label Aug 13, 2026

@Rich-Harris Rich-Harris left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Rich-Harris
Rich-Harris merged commit 2b9ed48 into sveltejs:version-3 Aug 13, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:svelte-package Issues related to svelte-package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

svelte-package not transforming glob import

3 participants