fix: rewrite TypeScript glob extensions (svelte-package) - #16776
Merged
Rich-Harris merged 1 commit intoAug 13, 2026
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/d84991704e34e14128c56a0f94dfd71f03c27f87Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: d849917 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #9423
With
rewriteRelativeImportExtensionsenabled,svelte-packagealready emits.tsmodules as.jsand rewrites explicit imports. Staticimport.meta.globpatterns were left pointing at the source extension, so they no longer matched the packaged files.This applies the same rewrite to relative static glob patterns, including arrays, negated patterns, and no-substitution template literals. Dynamic patterns and calls that are not Vite's exact
import.meta.globform remain unchanged.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkValidated with:
pnpm run formatpnpm run lintpnpm run checkpnpm -F @sveltejs/package testpnpm -F @sveltejs/kit test:unitChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits