Skip to content

chore: use unbundled type declarations for @sveltejs/kit/* modules - #16775

Draft
Rich-Harris wants to merge 1 commit into
version-3from
natural-types
Draft

chore: use unbundled type declarations for @sveltejs/kit/* modules#16775
Rich-Harris wants to merge 1 commit into
version-3from
natural-types

Conversation

@Rich-Harris

Copy link
Copy Markdown
Member

We use dts-buddy to bundle our types, but the original reason for doing so doesn't really apply any more, as far as the @sveltejs/kit/* modules go — everyone uses a modern moduleResolution option now (I think the legacy ones were removed or deprecated?) which means types resolve conditions in package.exports are reliable. So we don't need to use declare module for people to be able to see the types of subpackages.

We do still need it for $app/* modules, of course. But making this change speeds up prepublishOnly, and means that cmd-click works much more reliably (no sourcemaps between you and the code).

One thing I'm not sure about is why the RequestEvent and Cookies types are being inlined into $app/server rather than imported from @sveltejs/kit. Not sure off the top of my head if that's a bug in dts-buddy or a missing piece of config or something.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 8f2b6c3:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/8f2b6c30d67ae747713fcea4b68c98d8fcb0fdf0

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16775

@changeset-bot

changeset-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8f2b6c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant