fix: remove extra margin between multiline object

[jycouet]

I'm not sure if it was on purpose or not.

With today's margin, vite config looks like https://github.com/sveltejs/cli/blob/main/packages/sv/lib/cli/tests/snapshots/create-with-all-addons/vite.config.ts

What do you think ?

[changeset-bot]

🦋 Changeset detected

Latest commit: 3b0f385

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
esrap	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

npm i https://pkg.pr.new/sveltejs/esrap@100

commit: 3b0f385

[manuel3108]

I'm pretty sure this was added intentionally as this is the way code is formatted inside esrap and svelte codebases:

esrap/src/languages/ts/index.js

Lines 850 to 860 in 7a37005

	AssignmentExpression(node, context) {
	context.visit(node.left);
	context.write(` ${node.operator} `);
	context.visit(node.right);
	},
	AssignmentPattern(node, context) {
	context.visit(node.left);
	context.write(' = ');
	context.visit(node.right);
	},

and

https://github.com/sveltejs/svelte/blob/965bf6ceec0c6ee5347df6b04781fe9fe41aa5a5/packages/svelte/src/compiler/print/index.js#L455-L465

I haven't checked many more places, but this does appear to be intentional. But I do agree that this looks weird in some places like you showed. Maybe we could avoid adding this extra line break if [i-1] and [i] are ObjectExpressions? That should solve the problem at hand and still work good for other use cases

[jycouet]

extra line break if [i-1] and [i] are ObjectExpressions

That is just better!

[manuel3108]

LGTM, hoping for another approval though :D

[Rich-Harris]

not sure this is quite right — the test in this PR also passes on main, but IIUC the intent is to format things like this (in other words margin should only apply to statements, I guess?):

const obj = {
	before: 1,
	object: {
		a: 'lorem ipsum dolor sit amet',
		b: 'lorem ipsum dolor sit amet',
		c: 'lorem ipsum dolor sit amet',
		d: 'lorem ipsum dolor sit amet',
		e: 'lorem ipsum dolor sit amet'
	},
	array: [
		'lorem ipsum dolor sit amet',
		'lorem ipsum dolor sit amet',
		'lorem ipsum dolor sit amet',
		'lorem ipsum dolor sit amet',
		'lorem ipsum dolor sit amet'
	],
	after: 2
};

Right now, there's an unwanted new line between object and array:

const obj = {
	before: 1,
	object: {
		a: 'lorem ipsum dolor sit amet',
		b: 'lorem ipsum dolor sit amet',
		c: 'lorem ipsum dolor sit amet',
		d: 'lorem ipsum dolor sit amet',
		e: 'lorem ipsum dolor sit amet'
	},

	array: [
		'lorem ipsum dolor sit amet',
		'lorem ipsum dolor sit amet',
		'lorem ipsum dolor sit amet',
		'lorem ipsum dolor sit amet',
		'lorem ipsum dolor sit amet'
	],
	after: 2
};

[jycouet]

Thx, updated with your test

[Rich-Harris]

LGTM!