Reworked no-navigation-without-resolve to be more general and enable more edge cases

[marekdedic]

Fixes #1327

[changeset-bot]

🦋 Changeset detected

Latest commit: 117d4f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
eslint-plugin-svelte	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@117d4f6

Published Instant Preview Packages:

• eslint-plugin-svelte: https://pkg.pr.new/eslint-plugin-svelte@117d4f6

View Commit

[marekdedic]

Hello, I think this is ready for review now - I still want to add more edge cases (ternary expressions, function calls, array access), but those all need to build upon the structural changes introduced to this rule in this PR, so I'd prefer to merge this first and then add those as separate PRs.

I'd recommend reviewing this PR commit-by-commit, as the last commit is mostly building upon the re-structured rule and shows why such a rewrite is needed...

[marekdedic]

Rebased and ready for review :)

[ota-meshi]

The changes are so big that I think I'll need a large chunk of time to review this.
Because of this, I'm having trouble getting started on this review.
Could you split this PR into several PRs?
I think that would ultimately result in a faster release.

[marekdedic]

@ota-meshi Thanks. I'll try to make smaller PRs, however, for some things such as this one, they can only be done sequentially :/

Let's start with #1461.

[marekdedic]

Closing in favor of #1482. Most of the refactoring has already been merged in #1476 anyways.