docs: update vs code eslint config

[hyunbinseo]

ESLint errors were not being shown on typescript (.ts) files opened in VS Code.

Reference microsoft/vscode-eslint#2050

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2ef0c5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@2ef0c5b

Published Instant Preview Packages:

• eslint-plugin-svelte: https://pkg.pr.new/eslint-plugin-svelte@2ef0c5b

View Commit

[hyunbinseo]

@ota-meshi Sorry for the ping, but could you merge this? I haven't been getting inline lint errors due to this breaking change in the VS Code side.

[ota-meshi]

Thank you for the PR.
However, it seems that the "eslint.validate" setting will no longer be necessary in the next release of vscode-eslint.
microsoft/vscode-eslint#2090

Therefore, I think it's better to wait for the release of vscode-eslint and remove the "eslint.validate" setting.

[hyunbinseo]

I can confirm that Svelte linting no longer requires eslint.validate in the 3.0.21 pre-release.

Should the README be updated to:

• State the minimum VS Code extension version
• Inform existing users to remove the existing key?

The option from docs disables typescript-eslint lint results:

"eslint.validate": ["javascript", "javascriptreact", "svelte"]

[ota-meshi]

• State the minimum VS Code extension version
• Inform existing users to remove the existing key?

In my opinion, the documentation should simply state that users only need to use eslint-plugin-svelte and vscode-eslint will lint svelte files by default. No additional information is needed.
The extension will be updated automatically unless the user has disabled it.

[hyunbinseo]

dbaeumer.vscode-eslint@3.0.20 has just been released.

Users with the existing configuration will not see the TypeScript lint results inside the editor.

"eslint.validate": ["javascript", "javascriptreact", "svelte"]

Even after updating the VS Code ESLint extension, above configuration should be deleted since it does not include typescript.

Shouldn't there be a migration guide for existing users?

[ota-meshi]

Could you please modify this PR to remove the mention of "eslint.validate"?

[ota-meshi]

Please also update README.md.

eslint-plugin-svelte/README.md

Line 228 in a14f0ff

**Visual Studio Code**\

[sacrosanctic]

closed by #1500