Video support added.#437
Conversation
|
Waiting for being reviewed! |
|
@engasix sorry for the awaited late reply. May I know the purpose of adding video support? Since this repository mainly provides photo browsing options. Thanks and waiting for your reply! |
|
@tommyming sorry for the late reply. Modern galleries typically include both videos and images. If SKPhotoBrowser lacks video support, it risks falling behind. A content-based application cannot be considered complete without accommodating both media types. Consider a scenario where a developer needs to display images and videos related to a specific post or event. Would SKPhotoBrowser be their choice without video support? The answer is likely no. Thanks. |
|
@engasix thanks for the reply. I understand what you mean, and how the scenario works. But this repository is mainly for photo browsing, instead of media browsing. But overall would be a nice to have. I will take a look to the PR later. Thanks for contributing! |
|
Thank you @engasix for adding this feature, it worked for my needs as well! |
SKPhotoBrowser is a beautiful tool which save million of lives, only thing which I was missing is the video support, I tried my level best to write code following the same footprint, I hope my pull request will be accepted and I will become part of the community