Skip to content

Video support added.#437

Open
engasix wants to merge 3 commits intosuzuki-0000:masterfrom
engasix:master
Open

Video support added.#437
engasix wants to merge 3 commits intosuzuki-0000:masterfrom
engasix:master

Conversation

@engasix
Copy link
Copy Markdown

@engasix engasix commented Nov 24, 2022

SKPhotoBrowser is a beautiful tool which save million of lives, only thing which I was missing is the video support, I tried my level best to write code following the same footprint, I hope my pull request will be accepted and I will become part of the community

@engasix
Copy link
Copy Markdown
Author

engasix commented May 15, 2023

Waiting for being reviewed!

@tommyming
Copy link
Copy Markdown
Collaborator

@engasix sorry for the awaited late reply.

May I know the purpose of adding video support? Since this repository mainly provides photo browsing options.

Thanks and waiting for your reply!

@engasix
Copy link
Copy Markdown
Author

engasix commented Nov 22, 2024

@tommyming sorry for the late reply.

Modern galleries typically include both videos and images. If SKPhotoBrowser lacks video support, it risks falling behind. A content-based application cannot be considered complete without accommodating both media types.

Consider a scenario where a developer needs to display images and videos related to a specific post or event. Would SKPhotoBrowser be their choice without video support? The answer is likely no.

Thanks.

@tommyming
Copy link
Copy Markdown
Collaborator

@engasix thanks for the reply.

I understand what you mean, and how the scenario works.

But this repository is mainly for photo browsing, instead of media browsing.

But overall would be a nice to have. I will take a look to the PR later.

Thanks for contributing!

@azahid
Copy link
Copy Markdown

azahid commented Jun 23, 2025

Thank you @engasix for adding this feature, it worked for my needs as well!
@tommyming I know I am just a random person online but I vote +1 to add this to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants