feat: Phase 6 - Performance Budgets - #16
Merged
Merged
Conversation
- Install binaryen (wasm-opt) in the build job for WASM optimization - Add verification step to confirm wasm-opt ran successfully - Add perf-budget job with WASM gzipped size budget (1200 KB) - Add total bundle size budget check (1350 KB gzipped) - Upload build artifacts for budget verification
Add audit notes explaining: - Effect tracks only image-affecting signals (code, language, theme, split_*) - Non-visual signals (filename_template, ui_theme) are not tracked - Generation counter prevents stale async draws from wasting canvas work
Document oxipng WASM integration options: - @jsquash/oxipng npm package for browser use - Integration challenges (WASM-in-WASM, async boundary, perf trade-off) - Recommendation: defer to post-v1 due to complexity vs. marginal gains - Alternative: optional 'Optimize PNG' toggle with oxipng as Rust library
- Mark Phase 6 (Performance Budgets) as complete - Update current status section with Phase 6 details - Add v0.8 milestone to milestones table - Document CI budgets, wasm-opt, over-render audit, PNG optimization
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete Phase 6: Performance Budgets as defined in ROADMAP.md.
Changes
CI Performance Budgets (.github/workflows/ci.yml)
Over-Render Audit (crates/app/src/preview.rs)
PNG Optimization Exploration (docs/perf-baseline.md)
Version Bump
Acceptance Criteria (from ROADMAP.md)
CI Jobs
All existing jobs pass:
Part of Phase 6 in ROADMAP.md.