feat(expo): update for 1.1.5#215
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ⛔ Deployment terminated View logs |
superwall-docs-staging | 41ae540 | Jun 22 2026, 04:20 PM |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57fc6f15ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ### Patch Changes | ||
|
|
||
| - 45be124: Fix purchase events being dropped on cold start when using a custom purchase controller, which left the paywall spinner stuck forever. The native module emitted events through a single static reference that was overwritten by every module instance, so when more than one app context exists (e.g. expo-dev-client's launcher plus the app) the reference could point at an instance whose JS runtime never subscribed and `onPurchase`/`onPurchaseRestore` were silently dropped. Native events are now emitted to every live module instance (tracked weakly) instead of only the most recently created one. | ||
| - 85fce3f: add `shouldShowWebPurchaseConfirmationAlert` to `PaywallOptions` in compat |
There was a problem hiding this comment.
Remove non-upstream Expo changelog entry
The repository's AGENTS.md says SDK changelogs must copy reference/<sdk>/CHANGELOG.md verbatim; I checked the upstream Expo v1.1.5 CHANGELOG and the v1.1.4...v1.1.5 diff, and the changelog section only adds the 45be124 bullet. This extra 85fce3f line makes our docs claim an upstream release-note entry that was not published, even though that commit exists in the code diff, so the docs changelog should either remove this line or upstream should publish it first.
Useful? React with 👍 / 👎.
108f69d to
67758b0
Compare
67758b0 to
41ae540
Compare
Summary
Bumps the Superwall Expo SDK docs from
1.1.4→1.1.5.Upstream References
v1.1.4...v1.1.5Upstream Changelog Entry
Doc Changes
content/docs/expo/index.mdx— version marker updated:v1.1.4→v1.1.5content/docs/expo/sdk-reference/index.mdx— version marker updated:v1.1.4→v1.1.5content/docs/expo/changelog.mdx— 1.1.5 entry prepended additively (history preserved)Verification
bun test: 50 pass, 0 failbun run build:cf: OOM killed in sandbox (memory constraint); no code-level errorsFollow-up / Known Gaps
shouldShowWebPurchaseConfirmationAlertoption added to the compat layer does not have dedicatedreference docs in the Expo SDK section (no PaywallOptions reference page exists for Expo/compat).
This is consistent with the existing docs structure — changelog is the only place this is surfaced.