Skip to content

4.16.3 - #508

Merged
yusuftor merged 2 commits into
masterfrom
develop
Aug 19, 2026
Merged

4.16.3#508
yusuftor merged 2 commits into
masterfrom
develop

Conversation

@yusuftor

@yusuftor yusuftor commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Changes in this pull request

Promotes developmaster for the 4.16.3 patch release.

Fixes

  • Fixes a build error when compiling the SDK with Xcode 26.0. The fontScale device-attribute expression relied on Swift's implicit CGFloatDouble conversion, which Xcode 26.0's type-checker rejects as ambiguous (later toolchains resolve it). The arithmetic is now explicitly Double. (Fix build error on Xcode 26.0 from ambiguous CGFloat arithmetic #507)

🤖 Generated with Claude Code

Greptile Summary

This patch release makes the fontScale calculation explicit about converting UIKit’s CGFloat value to Double, resolving an Xcode 26.0 type-checking ambiguity without changing the calculated device attribute.

  • Bumps the SDK and CocoaPods versions to 4.16.3.
  • Adds the corresponding 4.16.3 changelog entry.
  • Preserves the existing two-decimal fontScale calculation and serialized Double contract.

Confidence Score: 5/5

The PR appears safe to merge because the numeric conversion preserves runtime behavior while resolving the targeted compiler ambiguity, and all release versions are synchronized.

The changed calculation continues producing the same rounded Double device attribute on supported targets, and the changelog, runtime SDK version, and podspec all consistently identify release 4.16.3.

Important Files Changed

Filename Overview
Sources/SuperwallKit/Network/Device Helper/DeviceHelper.swift Explicitly converts the UIKit CGFloat result to Double, fixing compiler ambiguity while preserving the existing rounded font-scale value.
Sources/SuperwallKit/Misc/Constants.swift Updates the runtime-reported SDK version to 4.16.3 in the canonical version location.
SuperwallKit.podspec Updates CocoaPods release metadata to the matching 4.16.3 version.
CHANGELOG.md Documents the Xcode 26.0 build fix under the new 4.16.3 release.

Reviews (1): Last reviewed commit: "Merge pull request #507 from superwall/f..." | Re-trigger Greptile

Context used:

yusuftor and others added 2 commits August 19, 2026 10:27
The fontScale expression mixed a CGFloat with Double and Int literals,
relying on the implicit CGFloat<->Double conversion. Xcode 26.0's
type-checker rejects it as an ambiguous use of '*' (with a cascading
error on the DispatchQueue.main.sync overload); later toolchains
resolve it. Converting to Double explicitly leaves one solution on
every toolchain.

Bumps the version to 4.16.3.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fix build error on Xcode 26.0 from ambiguous CGFloat arithmetic
@pullfrog

pullfrog Bot commented Aug 19, 2026

Copy link
Copy Markdown
  • Checkout PR 4.16.3 #508 and read full diff
  • Read summary snapshot and learnings
  • Triage: understand changes and gather context
  • Dispatch specialists if needed
  • Aggregate findings and draft review
  • Update summary snapshot
  • Submit review

Pullfrog  | View workflow run | via Pullfrog | Using Claude Opus𝕏

@yusuftor
yusuftor merged commit a999030 into master Aug 19, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant