Conversation
The fontScale expression mixed a CGFloat with Double and Int literals, relying on the implicit CGFloat<->Double conversion. Xcode 26.0's type-checker rejects it as an ambiguous use of '*' (with a cascading error on the DispatchQueue.main.sync overload); later toolchains resolve it. Converting to Double explicitly leaves one solution on every toolchain. Bumps the version to 4.16.3. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fix build error on Xcode 26.0 from ambiguous CGFloat arithmetic
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes in this pull request
Promotes
develop→masterfor the 4.16.3 patch release.Fixes
fontScaledevice-attribute expression relied on Swift's implicitCGFloat↔Doubleconversion, which Xcode 26.0's type-checker rejects as ambiguous (later toolchains resolve it). The arithmetic is now explicitlyDouble. (Fix build error on Xcode 26.0 from ambiguous CGFloat arithmetic #507)🤖 Generated with Claude Code
Greptile Summary
This patch release makes the
fontScalecalculation explicit about converting UIKit’sCGFloatvalue toDouble, resolving an Xcode 26.0 type-checking ambiguity without changing the calculated device attribute.fontScalecalculation and serializedDoublecontract.Confidence Score: 5/5
The PR appears safe to merge because the numeric conversion preserves runtime behavior while resolving the targeted compiler ambiguity, and all release versions are synchronized.
The changed calculation continues producing the same rounded
Doubledevice attribute on supported targets, and the changelog, runtime SDK version, and podspec all consistently identify release 4.16.3.Important Files Changed
CGFloatresult toDouble, fixing compiler ambiguity while preserving the existing rounded font-scale value.Reviews (1): Last reviewed commit: "Merge pull request #507 from superwall/f..." | Re-trigger Greptile
Context used: