Skip to content

Fix square corners on api 30 #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianrumac merged 2 commits into from
Jun 22, 2026
+34 −6
Merged

Fix square corners on api 30 #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbcafe0
Fix square corners on api 30
ianrumac Jun 22, 2026
7b95048
Update coverage badge [skip ci]
github-actions[bot] Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/badges/branches.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
38 changes: 33 additions & 5 deletions superwall/src/main/java/com/superwall/sdk/paywall/view/SuperwallPaywallActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,13 @@ import android.graphics.drawable.ColorDrawable
import android.graphics.drawable.GradientDrawable
import android.os.Build
import android.os.Bundle
import android.graphics.Outline
import android.view.View
import android.view.ViewGroup
import android.view.ViewOutlineProvider
import android.view.Window
import android.view.animation.OvershootInterpolator
import androidx.constraintlayout.widget.ConstraintLayout
import android.widget.FrameLayout
import androidx.activity.OnBackPressedCallback
import androidx.activity.SystemBarStyle
Expand Down Expand Up @@ -123,8 +126,8 @@ class SuperwallPaywallActivity : AppCompatActivity() {
ShimmerView(this@prepareViewForDisplay.context).apply {
layoutParams =
FrameLayout.LayoutParams(
((style.width * Resources.getSystem().displayMetrics.widthPixels) / 100).toInt(),
((style.height * Resources.getSystem().displayMetrics.heightPixels) / 100).toInt(),
FrameLayout.LayoutParams.MATCH_PARENT,
FrameLayout.LayoutParams.MATCH_PARENT,
)
}
} else {
Expand Down Expand Up @@ -509,15 +512,40 @@ class SuperwallPaywallActivity : AppCompatActivity() {
val container =
activityView.findViewById<FrameLayout>(com.superwall.sdk.R.id.container)

// Size the container as a percentage of the actual window bounds via ConstraintLayout
// constraints rather than display metrics, so it is correct on API 30-32 where
// setTranslucent(true) can exclude the nav bar from the window height.
val containerParams = container.layoutParams as ConstraintLayout.LayoutParams
containerParams.width = 0 // MATCH_CONSTRAINT
containerParams.height = 0 // MATCH_CONSTRAINT
containerParams.matchConstraintDefaultWidth = ConstraintLayout.LayoutParams.MATCH_CONSTRAINT_PERCENT
containerParams.matchConstraintDefaultHeight = ConstraintLayout.LayoutParams.MATCH_CONSTRAINT_PERCENT
containerParams.matchConstraintPercentWidth = (width.toFloat() / 100f).coerceIn(0.01f, 1f)
containerParams.matchConstraintPercentHeight = (height.toFloat() / 100f).coerceIn(0.01f, 1f)
container.layoutParams = containerParams

paywallView.layoutParams =
FrameLayout.LayoutParams(
((width * Resources.getSystem().displayMetrics.widthPixels) / 100).toInt(),
((height * Resources.getSystem().displayMetrics.heightPixels) / 100).toInt(),
FrameLayout.LayoutParams.MATCH_PARENT,
FrameLayout.LayoutParams.MATCH_PARENT,
)

val radius =
cornerRadius.toFloat() * Resources.getSystem().displayMetrics.density // Convert dp to px

container.background = roundedBackground(radius)
// Use a custom ViewOutlineProvider so clipToOutline works reliably on API 30-32.
// GradientDrawable.getOutline() with no fill color produces an empty outline on older
// Android, which causes clipToOutline to have no effect (square corners).
container.clipToOutline = true
container.outlineProvider =
object : ViewOutlineProvider() {
override fun getOutline(
view: View,
outline: Outline,
) {
outline.setRoundRect(0, 0, view.width, view.height, radius)
}
}

container.setOnClickListener { /* consume click */ }
container.addView(paywallView)
Expand Down