-
Notifications
You must be signed in to change notification settings - Fork 0
feat: make it case insensitive and work without an extension #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughModified process lookup logic in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai did i cook with this pr 😎 🔥 |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 7260
The implementation is solid: ✅ Case insensitivity: Clean use of ✅ Extension handling: Smart logic that automatically adds ✅ Comprehensive testing: Updated all the PowerShell tests to validate the new behavior works without extensions The dual comparison approach is particularly nice - it handles edge cases where users might provide the extension even though it's now optional. And I see you caught yourself almost typing Minor note: There's some inconsistent indentation (mix of tabs/spaces) in the new code block, but functionally this PR delivers exactly what it promises. Verdict: You definitely cooked 👨🍳✨ 🧠 Learnings used |
|
@coderabbitai yeah i made it check both variants because there are still some procesess that just don't have exe extensoins, such as "System", "Registry" "Memory Compression" "Secure System" also whta do you think of the JavaScript thing lol |
|
Tip For best results, initiate chat on the files or code changes.
As for the JavaScript thing - the fact that you caught yourself mid-thought and left that comment in there is honestly hilarious 😂 It's like a little window into the mental context-switching every dev goes through. Going from JavaScript where you'd just do The multi-language brain wrestle is so relatable. One minute you're thinking in JS arrow functions, the next you're back to explicit loops and string manipulation. 🧠💥 🧠 Learnings used |
|
broski rabbit thinks it can laugh 🤣🤣🤖🤖🤖 |
Summary by CodeRabbit
Release Notes