Skip to content

fix: Multi Params issue with @supermemory/tools#854

Open
MaheshtheDev wants to merge 5 commits intomainfrom
test-v6supermemory
Open

fix: Multi Params issue with @supermemory/tools#854
MaheshtheDev wants to merge 5 commits intomainfrom
test-v6supermemory

Conversation

@MaheshtheDev
Copy link
Copy Markdown
Member

testing for now

fix proxy issue

upgraded the package

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
🔵 In progress
View logs
supermemory-mcp 66ce119 Apr 15 2026, 10:37 PM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 15, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app b6a53ae Commit Preview URL

Branch Preview URL
Apr 15 2026, 10:49 PM

@MaheshtheDev MaheshtheDev marked this pull request as ready for review April 15, 2026 22:38
Copy link
Copy Markdown
Member Author


How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown

claude bot commented Apr 15, 2026

Claude finished @MaheshtheDev's task in 1m 5s —— View job


PR Review Complete

Overview: Fixes proxy/wrapper issue by switching from object spread to ES6 Proxy pattern to preserve prototype-chain properties on wrapped language models.

Issues found: None — this looks good to ship.

Details:

  • The core change in packages/tools/src/vercel/index.ts correctly solves the problem where { ...model } would drop prototype/getter properties like provider, modelId, and specificationVersion. The Proxy with Reflect.get(target, prop, receiver) properly delegates to the prototype chain.
  • Unit test added to verify the fix works for prototype-based properties (lines 90-107 in unit.test.ts).
  • Test app files cleaned up to use package imports (@supermemory/tools/*) instead of relative paths.
  • Version bump to 1.4.02 is appropriate for this fix.

Score: 9/10

Minor note: The test app changes (switching from OpenAI to Gemini gateway, adding PostHog tracing) are unrelated to the proxy fix. Not a blocker, but worth noting for commit message clarity.


@MaheshtheDev MaheshtheDev changed the title testing for now fix: Multi Params issue with @supermemory/tools Apr 15, 2026
@MaheshtheDev MaheshtheDev requested a review from Dhravya April 15, 2026 22:38
@MaheshtheDev MaheshtheDev linked an issue Apr 15, 2026 that may be closed by this pull request
The lockfile was out of sync with package.json dependencies, causing CI
to fail with --frozen-lockfile flag.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 15, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm entities is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: ?npm/entities@4.5.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/entities@4.5.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Fixes proxy/wrapper issue by switching from object spread to ES6 Proxy pattern to preserve prototype-chain properties on wrapped language models.

Issues found: None — this looks good to ship.

Details:

  • The core change in packages/tools/src/vercel/index.ts correctly solves the problem where { ...model } would drop prototype/getter properties like provider, modelId, and specificationVersion. The Proxy with Reflect.get(target, prop, receiver) properly delegates to the prototype chain.
  • Unit test added to verify the fix works for prototype-based properties.
  • Test app files cleaned up to use package imports (@supermemory/tools/*) instead of relative paths.
  • Version bump to 1.4.02 is appropriate for this fix.

Score: 9/10

Minor note: The test app changes (switching from OpenAI to Gemini gateway, adding PostHog tracing) are unrelated to the proxy fix. Not a blocker, but worth noting for commit message clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withSupermemory incompatible with AI SDK 6

1 participant