Skip to content

fix(pipecat): use client.add, memories.add was removed in supermemory 3.x#1326

Open
Cintu07 wants to merge 1 commit into
supermemoryai:mainfrom
Cintu07:fix/pipecat-memories-add-moved
Open

fix(pipecat): use client.add, memories.add was removed in supermemory 3.x#1326
Cintu07 wants to merge 1 commit into
supermemoryai:mainfrom
Cintu07:fix/pipecat-memories-add-moved

Conversation

@Cintu07

@Cintu07 Cintu07 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

supermemory_pipecat stores messages with client.memories.add(...), but
.add was moved off memories to the top level (client.add(...)) in
supermemory 3.x. the package pins supermemory>=3.16.0, a range where
memories.add no longer exists, so a fresh install pulls 3.51 and every
store raises AttributeError.

it's worse than a hard crash: the call sits in a fire-and-forget block that
only logs the error (service.py _store_messages), so memory silently never
gets stored and the user never sees why.

fix is one line: call client.add(**add_params). confirmed the top-level
add accepts the same params this passes (content, container_tags, custom_id,
metadata), and that client.memories.add is gone on current supermemory ^^

Copilot AI review requested due to automatic review settings July 21, 2026 20:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the supermemory_pipecat Python integration to match Supermemory 3.x’s client API by using the top-level client.add(...) method instead of the removed client.memories.add(...), preventing silent failures in the fire-and-forget message storage path.

Changes:

  • Update _store_messages to call await self._supermemory_client.add(**add_params) for Supermemory 3.x compatibility.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

add_params["custom_id"] = self.session_id

await self._supermemory_client.memories.add(**add_params)
await self._supermemory_client.add(**add_params)
@Cintu07

Cintu07 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

same root cause as #1236 (supermemory 3.x moved .add off .memories), just in
a different sdk. that one's an install-time cap, this one's a runtime call
that fails silently. this is very small and independent fix. so yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants