Skip to content

Add Nova workspace prompt settings#1323

Draft
vorflux[bot] wants to merge 7 commits into
mainfrom
vorflux/nova-workspace-persona
Draft

Add Nova workspace prompt settings#1323
vorflux[bot] wants to merge 7 commits into
mainfrom
vorflux/nova-workspace-persona

Conversation

@vorflux

@vorflux vorflux Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Adds a dedicated Workspace Prompt editor for Company Brain organizations while preserving the existing Organization Context ingestion-filter controls for every organization manager.

Changes

  • Keeps Organization Context byte-for-byte unchanged and available independently to all organization managers.
  • Adds Workspace Prompt as a separate Company-Brain-only section below it, using the established settings styling and contextual divider.
  • Describes Workspace Prompt as persistent guidance that can shape operating preferences, priorities, source/tool choices, workflows, terminology, formatting, and communication style.
  • Adds nullable, 1,500-character workspacePrompt support to shared request, GET response, and PATCH response contracts.
  • Aligns PATCH validation with the real { orgId, orgSlug, updated } API response.
  • Merges canonical updated settings into the submitting organization’s cache, then exactly refetches that organization.
  • Preserves drafts during background refetches, isolates organization switches, retains actionable errors, accessibility, empty filterPrompt compatibility, and X-App-Source: nova.

Testing

  • Passed focused Biome checks on all changed files.
  • Passed packages/lib and packages/validation TypeScript checks.
  • Verified GET/PATCH settings response contracts, partial/null/limit validation, canonical cache merge, and exact organization-bound invalidation.
  • Verified Organization Context remains unchanged and Workspace Prompt is separately Company-Brain/manager-gated.
  • Confirmed no remaining Workspace Persona identifiers.
  • Public preview returns HTTP 200; authenticated settings interactions remain unavailable without a saved OAuth session.
  • Full web type-check remains blocked by unrelated baseline diagnostics; none reference changed files.
  • No dedicated tests were added, per requester instruction.

Session Details

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 21, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 562e721 Jul 21 2026, 04:36 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 21, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 562e721 Commit Preview URL

Branch Preview URL
Jul 21 2026, 04:37 PM

@vorflux
vorflux Bot marked this pull request as draft July 21, 2026 11:41
Comment thread apps/web/hooks/use-org-settings.ts Outdated
Comment on lines +56 to +57
if (response.error) {
throw new Error(response.error.message || "Failed to save settings")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide requires always using new Error() when throwing errors and including any supporting data as the cause argument instead of inlining it into the string. The error message is constructed by concatenating response.error.message with a fallback string (response.error.message || "Failed to save settings"). The supporting data (response.error.message) should be passed as the cause option: throw new Error("Failed to save settings", { cause: response.error.message }).

Suggested change
if (response.error) {
throw new Error(response.error.message || "Failed to save settings")
if (response.error) {
throw new Error("Failed to save settings", { cause: response.error.message })

Spotted by Graphite (based on custom rule: TypeScript style guide (Google))

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 1ea6e2dd: the save failure now uses a stable Error message and preserves the API detail in cause. Focused Biome and git diff --check pass.

@vorflux vorflux Bot changed the title Add Nova workspace persona settings Add Nova workspace prompt settings Jul 21, 2026

@sreedharsreeram sreedharsreeram left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant