Fix plugin memory parser attribution#1049
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-app | 8288ed9 | Commit Preview URL Branch Preview URL |
Jun 04 2026, 02:24 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-mcp | 8288ed9 | Jun 04 2026, 02:23 PM |
|
Claude finished @ved015's task in 1m 45s —— View job Reviewed PR #1049
Summary: This PR properly fixes plugin memory attribution by recognizing Score: 10/10 — Clean code, ready to ship. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview: Refactors plugin document parsing to properly attribute memories to their source plugin (Claude Code, Codex, OpenClaw, Hermes, etc.) based on source metadata rather than content heuristics.
Issues found: None — this looks good to ship.
The changes are well-structured:
pluginIdentityFromSource()correctly maps source strings to plugin identities with proper normalizationgetDocumentPluginIdentity()has a sensible fallback chain: document.source → sm_source → sm_client → sm_internal_mcp_client_name → space detection- Scoping
parseRoleBlockTranscript()to OpenClaw and Hermes only is correct since other plugins don't use that format - The
detectPluginSource()fix to accept both "claude-code" and "claude-code-plugin" prevents misattribution to Codex - Hermes additions are consistent with existing plugin patterns
Score: 10/10
There was a problem hiding this comment.
Overview: Refactors plugin document parsing to properly attribute memories to their source plugin (Claude Code, Codex, OpenClaw, Hermes, etc.) based on source metadata rather than content heuristics.
Issues found: None — this looks good to ship.
The changes are well-structured:
pluginIdentityFromSource()correctly maps source strings to plugin identities with proper normalizationgetDocumentPluginIdentity()has a sensible fallback chain: document.source → sm_source → sm_internal_mcp_client_name → space detection- Scoping
parseRoleBlockTranscript()to OpenClaw and Hermes only is correct since other plugins don't use that format - The
detectPluginSource()fix to accept both "claude-code" and "claude-code-plugin" prevents misattribution to Codex - Hermes additions are consistent with existing plugin patterns
Score: 10/10
2 participants
Summary
claude-codeas Claude Code source metadata, not Codex[SAVE:...]memories using the detected plugin identity