ENG-712: Accept JSON uploads in Nova + fix file-size display#1047
Conversation
MaheshtheDev
commented
Jun 4, 2026
MaheshtheDev
commented
- Accept .json / application/json files in the add-document uploader.
- Show file sizes in B/KB/MB instead of always '0.00 MB' for small files.
- Accept .json / application/json files in the add-document uploader. - Show file sizes in B/KB/MB instead of always '0.00 MB' for small files.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-app | 004714a | Commit Preview URL Branch Preview URL |
Jun 04 2026, 08:18 AM |
How to use the Graphite Merge QueueAdd the label Main to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-mcp | 004714a | Jun 04 2026, 08:17 AM |
|
Claude finished @MaheshtheDev's task in 51s —— View job Review Complete
Summary: Reviewed PR for JSON upload support and file-size display fix. No bugs, security issues, or logic errors found. The implementation is clean and consistent with existing patterns. Submitted review with score 10/10. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview: Adds JSON file upload support and fixes file size display to show human-readable units instead of always showing MB.
Issues found: None — this looks good to ship.
The implementation is clean:
- JSON support correctly adds both the
.jsonextension to the allowed set and theapplication/jsonMIME type check, consistent with existing patterns formatFileSize()handles edge cases properly (bytes < 1024 shown as B, correct unit progression, bounds-checking on array index, appropriate decimal precision)
Score: 10/10
2 participants
