Skip to content

fix: images are missing for the document in edit mode #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harbournick merged 4 commits into from
Sep 2, 2025
Merged

fix: images are missing for the document in edit mode #831

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8287bb9
fix: images are missing for the document in edit mode
VladaHarbour Sep 1, 2025
6b19e73
test: update image import/export tests
VladaHarbour Sep 2, 2025
de87295
fix: remove regex
VladaHarbour Sep 2, 2025
1004040
Merge branch 'main' into ide-7_images
harbournick Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/super-editor/src/core/DocxZipper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ class DocxZipper {
name: zipEntry.name,
content,
});
} else if (zipEntry.name.startsWith('word/media') && zipEntry.name !== 'word/media/') {
} else if (
(zipEntry.name.startsWith('word/media') && zipEntry.name !== 'word/media/') ||
(zipEntry.name.startsWith('media') && zipEntry.name !== 'media/')
) {
// If we are in node, we need to convert the buffer to base64
if (isNode) {
const buffer = await zipEntry.async('nodebuffer');
Expand Down
6 changes: 5 additions & 1 deletion packages/super-editor/src/core/super-converter/v2/importer/imageImporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,12 @@ export function handleImageImport(node, currentFileName, params) {
if (!rel) return null;

const { attributes: relAttributes } = rel;
const targetPath = relAttributes['Target'].startsWith('/')
? relAttributes['Target'].slice(1)
: relAttributes['target'];

const path = `word/${relAttributes['Target']}`;
// Some images may appear out of the word folder
const path = targetPath.startsWith('word') || params.converter.media[targetPath] ? targetPath : `word/${targetPath}`;

return {
type: 'image',
Expand Down
5 changes: 4 additions & 1 deletion packages/super-editor/src/dev/components/DeveloperPlayground.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import '@/style.css';
import '@harbour-enterprises/common/styles/common-styles.css';

import { ref, shallowRef, computed, onMounted } from 'vue';
import { NMessageProvider } from 'naive-ui';
import { SuperEditor } from '@/index.js';
import { getFileObject } from '@harbour-enterprises/common/helpers/get-file-object';
import { DOCX } from '@harbour-enterprises/common';
Expand Down Expand Up @@ -158,7 +159,9 @@ onMounted(async () => {
</div>

<div class="dev-app__content" v-if="currentFile">
<SuperEditor :file-source="currentFile" :options="editorOptions" />
<n-message-provider>
<SuperEditor :file-source="currentFile" :options="editorOptions" />
</n-message-provider>
</div>
</div>
</div>
Expand Down
Loading